search

trafficonese / leaflet.extras2

Extra functionality for leaflet R package.
https://trafficonese.github.io/leaflet.extras2/
GNU General Public License v3.0
85 stars 20 forks source link

addWMS() does not hide the attribution when corresponding group is hidden #55

Open florisvdh opened 1 year ago

florisvdh commented 1 year ago

After adding a WMS layer withaddWMS(), the attribution display at the bottom is not toggled when the group is shown or hidden respectively. This contrasts with such toggle-behaviour in leaflet::addWMSTiles(), where the attribution is hidden if the group is hidden.

The attached zipped html notebook – leaflet_issue_notebook.nb.html.zip – compares this behaviour between leaflet (first map) and leaflet.extras2 (second map).

I believe leaflet.extras2 should follow the behaviour of leaflet for this.

trafficonese commented 1 year ago

You're right, but I do think the bug comes from the underlying plugin library. I will have a deeper look into it, or you could open an Issue here https://github.com/heigeo/leaflet.wms

trafficonese commented 1 year ago

https://github.com/heigeo/leaflet.wms/issues/76