search

traffordDataLab / leaflet.reachability

Plugin for the Leaflet JavaScript library to show areas of reachability based on time or distance for different modes of travel using the openrouteservice isochrones API.
MIT License
64 stars 7 forks source link

Add support for Valhalla #8

Closed webmap2015 closed 2 years ago

webmap2015 commented 3 years ago

Hi, there's a isochrone API and it's pretty fast: 'https://valhalla.interline.io/isochrone?'

Could you add support for Valhalla?

Thanks.

itsozz commented 3 years ago

Hi, thanks for getting in touch. At the moment the plugin is very closely coupled to the openrouteservice isochrones API. In order to provide support for alternative APIs I'd have to look carefully at the inputs and outputs expected from the different services and abstract certain parts of the plugin etc. Not saying it wouldn't be possible, but it would require a reasonable amount of change.

What do you think would be the benefits to offering support for Valhalla, and other APIs perhaps, over just using openrouteservice?

webmap2015 commented 3 years ago

Of course, lots of plugins, especially Routing and Geocoding, support many different data providers.

itsozz commented 3 years ago

So the benefit is for the map developer in terms of choice, i.e. they already have an API key setup with one provider, e.g. Valhalla, and would therefore prefer to use that rather than having to create another with openrouteservice due to it being the only one supported?

My current priority is improving the accessibility of the plugin, but this is certainly something I can consider for future development.

nilsnolde commented 3 years ago

@itsozz I recently wrote an overview article about FOSS routing engines: https://gis-ops.com/open-source-routing-engines-and-algorithms-an-overview/ (little #shamelessplug I guess;)). In short: Valhalla is great for isochrones as well, you can add all kinds of constraints to each request, which is what most others (incl ORS) lack.

itsozz commented 3 years ago

Hi @nilsnolde, great to hear from you! Thanks very much for this and the informative article - really interesting and lots to consider.

webmap2015 commented 3 years ago

Hi, I found a sample https://www.mapzen.com/products/mobility/isochrone/

webmap2015 commented 2 years ago

I made it.