search

trafi / anchor-bottom-sheet-behavior

BottomSheet behavior with collapsed, expanded and anchor states
Apache License 2.0
173 stars 25 forks source link

Fixes issue with small bottom sheet content #7

Closed sregg closed 6 years ago

sregg commented 6 years ago

Fixes https://github.com/trafi/anchor-bottom-sheet-behavior/issues/6

sregg commented 6 years ago

You're right. That's an half-ass fix... Would you mind having a look a pushing a fix on your repo?

On Fri, Apr 27, 2018, 6:36 PM Justas Medeisis notifications@github.com wrote:

@justasm commented on this pull request.

Thanks for the contribution!

This mostly works but doesn't cover all the uses of mAnchorOffset, e.g. shouldCollapse should also consider the offset when calculating whether the sheet is to collapse or anchor upon release. With the current solution, if the content height does not extend beyond the midpoint of collapsed ( mMaxOffset) and anchored (mMinOffset in the case at issue here), the sheet will always collapse regardless of the position that it is released at.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/trafi/anchor-bottom-sheet-behavior/pull/7#pullrequestreview-116101071, or mute the thread https://github.com/notifications/unsubscribe-auth/ABaSc3IBJBjM3OUsKxowyNGX5Tck9XETks5ts511gaJpZM4TrChy .

justasm commented 6 years ago

Thanks for your initial work, this has been incorporated into #14.