word2phrase: AddWord2Vocab strcpy's full length of strings longer than MAX_STRING

traghav / word2vec

Automatically exported from code.google.com/p/word2vec

Apache License 2.0

0 stars 0 forks source link

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago

The strcmp should be changed to strncmp.  This may be causing segmentation 
faults in some cases when the input contains words that are too long.

Original issue reported on code.google.com by chad.p...@gmail.com on 17 Jul 2015 at 11:12

GoogleCodeExporter commented 8 years ago

Also, in SortVocab() the free is indexed to vocab_size, not the element 
actually being freed.

Original comment by chad.p...@gmail.com on 17 Jul 2015 at 11:26