search

trailblazer / cells-haml

Haml integration for Cells
https://github.com/trailblazer/cells-haml
MIT License
5 stars 13 forks source link

Depend on stable version of cells. #3

Closed jish closed 8 years ago

jish commented 8 years ago

Cells is currently at version 4.0.4. There is no reason to be depending on an unstable release anymore.

jish commented 8 years ago

I'm not sure why there is build error when attempting to install the haml gem. According to RubyGems.org version 4.0.7 or haml is actually more recent (August 10, 2015) than 4.1.0.beta.1 (January 7, 2014).

timoschilling commented 8 years ago

Cells need a fix wich is only in haml 4.1.0.beta.1 and not in 4.0.x

jish commented 8 years ago

"Cells need a fix wich is only in haml 4.1.0.beta.1 and not in 4.0.x"

Yes, I agree. That is why I left the haml dependency alone in this changeset

-  spec.add_dependency 'cells', '~> 4.0.0.beta6'
+  spec.add_dependency 'cells', '~> 4.0.1'
   spec.add_dependency 'haml', '>= 4.1.0.beta.1'

Sorry if I was not clear. I was referring to the build failure on this branch / pull request https://travis-ci.org/trailblazer/cells-haml/builds/114590700.

An error occurred while installing haml (4.1.0.beta.1), and Bundler cannot continue.

The haml related build failure seems to be ocurring in all of the master branch builds since January 31st, 2016 https://travis-ci.org/trailblazer/cells-haml/builds.