search

trailblazer / cells

View components for Ruby and Rails.
https://trailblazer.to/2.1/docs/cells.html
3.07k stars 236 forks source link

Cell::I18n #377

Closed Kledal closed 8 years ago

Kledal commented 8 years ago

This PR is ongoing and tries to complete the work started in #279 fixes #272

This scopes the translation key to the following: Given a Cell called I18nConcept::Testing a call to t('.test') will produce the following key: cells.i18n_concept.testing.test

Kledal commented 8 years ago

@apotonick Please review whenever you have the time :smile:

apotonick commented 8 years ago

Does this PR need https://github.com/apotonick/cells/pull/279 ? Wondering because you're using super in def t, and I can't find out where #t comes from.

This should all go to cells-rails, I don't want any Rails-specific code in Cells anymore. Also, shouldn't we test that with normal cells and concept cells?

Thanks!!!

Kledal commented 8 years ago

Could you point me to where cells-rails is located. I've tried to look for it at Trailblazer and in your gems. But I'm properly overlooking something.

apotonick commented 8 years ago

Haha, it doesn't exist, yet, we have to create it!

Kledal commented 8 years ago

Lets do it! I'm ready :smile:

apotonick commented 8 years ago

https://github.com/trailblazer/cells-rails :heart:

scarfacedeb commented 8 years ago

Any news on this one? ✌️

apotonick commented 8 years ago

Yeah, this would go to cells-rails. :grimacing: