Button controls should render "value" attributes

trailblazer / formular

Form builder for Ruby. Fast, Furious, and Framework-Agnostic.

MIT License

81 stars 17 forks source link

Closed bencallaway closed 7 years ago

bencallaway commented 7 years ago

This PR adds breaking changes:

Formular::Element::Button no longer blacklists value attributes passed as an option
Formular::Element::Button#content is no longer overridden by the :value option
Updated tests to reflect the new expected output.

fran-worley commented 7 years ago

Good spot! 👍 Thanks very much!!