trailblazer / formular

Form builder for Ruby. Fast, Furious, and Framework-Agnostic.
MIT License
81 stars 17 forks source link

Button type attribute would ideally not have a default #59

Closed bencallaway closed 2 years ago

bencallaway commented 6 years ago

A <button> element's type attribute can be omitted, and if so its implicit value is "submit".

I would expect Formular::Element::Button.(value: 'foo') { 'Foo' } to produce

<button value="foo">Foo</button>

instead of

<button value="foo" type="button">Foo</button>

I realize would be a 'breaking' change since the last commit , but if it's an admissible change I can submit a PR