search

trailblazer / reform

Form objects decoupled from models.
https://trailblazer.to/2.1/docs/reform.html
MIT License
2.49k stars 184 forks source link

AM error handling issues #479

Closed emaglio closed 4 years ago

emaglio commented 5 years ago

This might have some duplicates in the issues list but I want just to add here to keep track of it. Here what Sam wrote to me today: image image image https://www.morozov.is/2019/05/31/upgrading-dry-gems.html

emaglio commented 5 years ago

Updates from Sam: image https://github.com/samstickland/reform/tree/2.2.5 https://github.com/samstickland/reform-rails/tree/0.1.8 https://github.com/samstickland/reform-rails/commit/f11a2bc0e8f51a25e8fb7b59bb804c45990f68f5 https://github.com/samstickland/reform-rails/commit/e8b4d863f4b78b66affeead3e2d29f3ec9182002 image image

samstickland commented 5 years ago

Experimental PRs that revert and fix things to a state that is backwards compatible with reform 2.2 and works with Rails 5.1 and Rails 5.2

https://github.com/trailblazer/reform/pull/490 https://github.com/trailblazer/reform-rails/pull/70

emaglio commented 4 years ago

@samstickland do you think we can close this?

samstickland commented 4 years ago

Yes. It's not needed now, all the fixes we need are on the master branches.