trailblazer / rspec-cells

Spec your Cells.
http://cells.rubyforge.org
MIT License
62 stars 48 forks source link

rspec 3 #56

Closed magicmarkker closed 9 years ago

magicmarkker commented 10 years ago

Any plans to update this to use rspec 3?

seuros commented 10 years ago

It already work with rspec 3.

magicmarkker commented 10 years ago

Not the newest version, I keep getting `<module:CellExampleGroup>': uninitialized constant Cell::TestCase::TestMethods (NameError) which im trying to fix locally now to pull request.

apotonick commented 10 years ago

Mark, are you running on cells master?

We're still working on it, the rspec-cells pendant will be out shortly after that and might probably have 10 lines of code.

magicmarkker commented 10 years ago

@apotonick yep, running master. In the meantime I have a local copy that fixes the errors I was getting. I'll just use that until the update. Thanks!

apotonick commented 10 years ago

You're running master? :heart: :heart: :heart: Tough boy!

@seuros will keep you up-to-date with his progress on rspec-cells, right, @seuros ?

seuros commented 10 years ago

yeah!

tbrooke commented 9 years ago

So what about the fix - I'm getting the same error with rspec 3 `module:CellExampleGroup': uninitialized constant Cell::TestCase::TestMethods (NameError)

apotonick commented 9 years ago

We'll merge cells-4 into master this week, and I'm working on Test::Unit support as I type, so the rspec-cells gem should be up and running within a few days.

tbrooke commented 9 years ago

Thanks

On Sun, Feb 1, 2015 at 10:37 PM, Nick Sutterer notifications@github.com wrote:

We'll merge cells-4 into master this week, and I'm working on Test::Unit support as I type, so the rspec-cells gem should be up and running within a few days.

— Reply to this email directly or view it on GitHub https://github.com/apotonick/rspec-cells/issues/56#issuecomment-72402549 .

namxam commented 9 years ago

Sounds awesome. We just replaced a few draper decorators/partials with cells and are really happy about it. But being able to verify it with specs would be nice ;)

dgilperez commented 9 years ago

Keep the good work! can't wait for cells 4! :+1:

seuros commented 9 years ago

@dgilperez cells 4 is out.

dgilperez commented 9 years ago

@seuros ups! rspec-cells testable?

seuros commented 9 years ago

Not yet.

apotonick commented 9 years ago

It is actually extremely simple to implement this for rspec, now. Look, how we grab the cell instance for Test::Unit/MiniTest.

This is the 3-line TestCase implementation: https://github.com/apotonick/cells/blob/master/lib/cell/test_case.rb

And the Rspec example or, whatever it's called, basically has to include the Cell::Testing module: https://github.com/apotonick/cells/blob/master/lib/cell/testing.rb

I'm totally open for changes here! The Testing module is a first draft but works for me. We still have to sort out wrapping the rendered states in a Capybara.string but that's a MiniTest thing.

Anyone wanna give it a go? :beers: