trailheadapps / dreamhouse-lwc

Sample application for Lightning Web Components on Salesforce Platform. Part of the sample gallery. Real estate use case. Get inspired and learn best practices.
https://developer.salesforce.com
Apache License 2.0
391 stars 779 forks source link

Fixes to warnings from SLDS validator and some mobile fixes #438

Closed albarivas closed 2 years ago

albarivas commented 2 years ago

What does this PR do?

Fixes to warnings from SLDS validator and some mobile fixes

What issues does this PR fix or reference?

The PR fulfills these requirements:

[N/A] Tests for the proposed changes have been added/updated. [X] Code linting and formatting was performed.

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

github-actions[bot] commented 2 years ago

⚠️ CodeTour Watch

Changed files with possible CodeTour impact:

Impacted CodeTour files:

Make sure to review CodeTour files and update line numbers accordingly.

codecov[bot] commented 2 years ago

Codecov Report

Merging #438 (56d821d) into main (3313f15) will decrease coverage by 0.23%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
- Coverage   91.70%   91.46%   -0.24%     
==========================================
  Files          19       19              
  Lines         434      422      -12     
  Branches       27       27              
==========================================
- Hits          398      386      -12     
  Misses         36       36              
Flag Coverage Δ
Apex 98.30% <ø> (ø)
LWC 88.81% <ø> (-0.43%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce-app/main/default/lwc/propertyMap/propertyMap.js 59.25% <0.00%> (-1.46%) :arrow_down:
...ain/default/lwc/propertySummary/propertySummary.js 65.21% <0.00%> (-1.45%) :arrow_down:
...n/default/lwc/propertyTileList/propertyTileList.js 81.81% <0.00%> (-0.80%) :arrow_down:
...-app/main/default/lwc/daysOnMarket/daysOnMarket.js 95.34% <0.00%> (-0.11%) :arrow_down:
force-app/main/default/lwc/paginator/paginator.js 100.00% <0.00%> (ø)
...orce-app/main/default/lwc/brokerCard/brokerCard.js 100.00% <0.00%> (ø)
...orce-app/main/default/lwc/errorPanel/errorPanel.js 100.00% <0.00%> (ø)
...-app/main/default/lwc/propertyTile/propertyTile.js 100.00% <0.00%> (ø)
.../main/default/lwc/barcodeScanner/barcodeScanner.js 100.00% <0.00%> (ø)
.../main/default/lwc/propertyFilter/propertyFilter.js 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us.