search

trailofbits / SecureEnclaveCrypto

Demonstration library for using the Secure Enclave on iOS
Apache License 2.0
279 stars 41 forks source link

Swift example #5

Closed hfossli closed 7 years ago

hfossli commented 7 years ago

(these commits can (should) be squashed)

hfossli commented 7 years ago

Any reason for this taking so long? I am in fact considering closing this pull request and withdrawing my offer to contribute to this repo. I don't see myself creating new pull requests taking months to fulfill or even get feedback on. If things are to change then I'm here to stay, but if you're just pressing "merge" I don't see that as a meaningful conversation taking place. Just being honest. Let me know what you think.

withzombies commented 7 years ago

Sorry, we've been busy. I'll be able to get to it next week.

withzombies commented 7 years ago

Sorry this took so long. This looks good, I just have one request: could you explicitly specify the Apache2 license in the following files:

Right now they're marked as "All Rights Reserved.", which prevents them from being used as open source libraries. Once those are updated, I'll accept the merge and update the README.

withzombies commented 7 years ago

Thanks @hfossli. Sorry about the delay.

hfossli commented 7 years ago

Awesome. I guess I'll be reviewing future pull requests and issue tracking regarding the swift code. Would be cool to join this repo as a contributor with write access in that sense.

hfossli commented 7 years ago

Cool! 👍🎉