trailofbits / algo

Set up a personal VPN in the cloud
https://blog.trailofbits.com/2016/12/12/meet-algo-the-vpn-that-works/
GNU Affero General Public License v3.0
28.98k stars 2.32k forks source link

feat: add support for vultr api v2 #14587

Open dhruvkelawala opened 1 year ago

dhruvkelawala commented 1 year ago

Description

Added support for Vultr Api v2 as new accounts on Vultr won't be able to use v1 api. Old accounts will be unable to use v1 api after June 2023.

Motivation and Context

This change makes sure AlgoVPN can be use by new and old users of Vultr

Fixes #14580

How Has This Been Tested?

Tested by Creating a VPS on Vultr with Ubuntu on my macbook m1

Types of changes

Checklist:

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

cooper667 commented 1 year ago

👍 Worked well for me, thanks

dhruvkelawala commented 1 year ago

Waiting for it to be merged. Not sure if it will ever be 😂

dhruvkelawala commented 1 year ago

Thanks for the review! Please feel free to merge 🙂

dhruvkelawala commented 1 year ago

@pentest01 @mkurapov Any plans to merge this and make a release?

amitai commented 1 year ago

Hi, would love to see this released.

amitai commented 11 months ago

I tried with this fork and still got the API error:

TASK [cloud-vultr : Creating a firewall group] *********************************************************************************
fatal: [localhost]: FAILED! => {"changed": false, "msg": "Reached API retries limit 5 for URL https://api.vultr.com/v1/firewall/group_list, method GET with data None. Returned 503, with body: HTTP Error 503: API v1 Gone b'Sorry, all newly created accounts are forbidden from using API v1, all other accounts are able to use this deprecated API until September 30, 2023 at which point Vultr API v1 will be sunset. Please use API v2.'", "vultr_api": {"api_account": "default", "api_endpoint": "https://api.vultr.com", "api_retries": 5, "api_retry_max_delay": 12, "api_timeout": 60}, "vultr_firewall_group": {}}
jackivanov commented 11 months ago

Sorry for my delay. Feel free to rebase and I'll review

dhruvkelawala commented 11 months ago

Will do it