trailofbits / binary_type_inference

GNU General Public License v3.0
15 stars 2 forks source link

Maintain Knowledge of Shared Subgraphs for Lowering #8

Closed 2over12 closed 2 years ago

2over12 commented 2 years ago

Currently after sketches are labeled there is no knowledge of which nodes in a sketch correspond to nodes in the original constraint graph. Ideally, we would maintain some way to identify shared subgraphs between sketches. The idea being we should build some dependency graph of lowering shared subgraphs where a shared sketch subgraph is represented by a singular C type.

2over12 commented 2 years ago

https://github.com/trailofbits/binary_type_inference/commit/496af7f552d433a2ad01a1881de5e71a6e44cf0a Fixes this by computing sketch labeling over the entire constraint graph rather than individual sketches. This constraint graph can be passed to the datalog as is