trailofbits / krf

A kernelspace syscall interceptor and randomized faulter
https://blog.trailofbits.com/2019/01/17/how-to-write-a-rootkit-without-really-trying/
GNU General Public License v3.0
349 stars 35 forks source link

fix conflicting types for ‘sys_call_table’ #87

Closed lpirl closed 2 years ago

lpirl commented 2 years ago

Dear team of @trailofbits,

first, thanks a lot for (open sourcing) this smart and versatile project.

When trying to compile for Linux 5.10 on Debian 11 (Bullseye), I experienced the following error:

In file included from /root/krf/src/module/linux/krf.c:11:
/root/krf/src/module/linux/syscalls.h:37:24: error: conflicting types for ‘sys_call_table’
   37 | extern unsigned long **sys_call_table;
      |                        ^~~~~~~~~~~~~~
In file included from /usr/src/linux-headers-5.10.0-11-common/arch/x86/include/asm/elf.h:15,
                 from /usr/src/linux-headers-5.10.0-11-common/include/linux/elf.h:6,
                 from /usr/src/linux-headers-5.10.0-11-common/include/linux/module.h:18,
                 from /root/krf/src/module/linux/krf.c:1:
/usr/src/linux-headers-5.10.0-11-common/arch/x86/include/asm/syscall.h:21:29: note: previous declaration of ‘sys_call_table’ was here
   21 | extern const sys_call_ptr_t sys_call_table[];
      |                             ^~~~~~~~~~~~~~
make[4]: *** [/usr/src/linux-headers-5.10.0-11-common/scripts/Makefile.build:285: /root/krf/src/module/linux/krf.o] Error 1
make[3]: *** [/usr/src/linux-headers-5.10.0-11-common/Makefile:1846: /root/krf/src/module/linux] Error 2
make[2]: *** [/usr/src/linux-headers-5.10.0-11-common/Makefile:185: __sub-make] Error 2
make[1]: *** [Makefile:20: module] Error 2
make: *** [Makefile:12: module] Error 2

This pull request fixed the name clash for me.

I have really close to no cred in kernel development, so please excuse an stupidity.

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

lpirl commented 2 years ago

Dear owners/maintainers: I had a typo in the branch name and would be happy if you would delete my faux pas from the Internet (i.e., delete this PR): :) Thanks.