mx-list-macros example not working

trailofbits / multiplier

Code auditing productivity multiplier.

Apache License 2.0

437 stars 27 forks source link

mx-list-macros example not working #480

Closed pgoodman closed 11 months ago

pgoodman commented 11 months ago

The bug is actually in the indexer:

(Release) pag@m2sloth multiplier % sqlite3 ~/Install/curl.db 
SQLite version 3.39.5 2022-10-14 20:58:05
Enter ".help" for usage hints.
sqlite> select count(*) from fragment_with_MACRO_DEFINE_DIRECTIVE;
0

pgoodman commented 11 months ago

This was a simple oversight in the indexer. Because tokentree stuff is handled differently in terms of entity maps, the code in SerializePendingFragment.cpp that calls db.AsyncIndexFragmentSpecificEntity wasn't applying to macros.