trailofbits / onesixtyone

Fast SNMP Scanner
GNU General Public License v2.0
525 stars 88 forks source link

Debian patches to onesixtyone #24

Closed charles2910 closed 1 year ago

charles2910 commented 1 year ago

Hi, there are a couple patches Debian is applying to onesixtyone and it would be nice to see them incorporated upstream. They are:

Description: Add missing flags
Author: Sophie Brun <sophie@offensive-security.com>
Last-Update: 2019-04-02
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
 onesixtyone: onesixtyone.c
-   gcc -o onesixtyone onesixtyone.c
+   gcc $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) -o onesixtyone onesixtyone.c

 solaris: onesixtyone.c
    cc -o onesixtyone onesixtyone.c -lsocket -lnsl

and

Description: don't hard codes the build architecture compiler
 onesixtyone fails to cross build from source, because the upstream
 Makefile hard codes the build architecture compiler "gcc". Making it
 substitutable is sufficient for making onesixtyone cross buildable.
Author: Helmut Grohne <helmut@subdivi.de>
Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=930902
Last-Update: 2019-07-08
---
This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
--- a/Makefile
+++ b/Makefile
@@ -1,5 +1,5 @@
 onesixtyone: onesixtyone.c
-   gcc $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) -o onesixtyone onesixtyone.c
+   $(CC) $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) -o onesixtyone onesixtyone.c

 solaris: onesixtyone.c
    cc -o onesixtyone onesixtyone.c -lsocket -lnsl

If you'd like to see them upstreamed, I could open a PR.

Cheers!

charles2910 commented 1 year ago

There is also a manpage based on the helper text printed by onesixtyone.

woodruffw commented 1 year ago

Hi @charles2910! Yes, please do open a PR with those changes, thanks!

charles2910 commented 1 year ago

Thanks for merging. It'd be really cool if you released a new version - 0.3.4 I think :-)

woodruffw commented 1 year ago

Sure, I can do that tomorrow. Sent from mobile. Please excuse my brevity.On Dec 27, 2022, at 7:42 PM, Carlos Henrique Lima Melara @.***> wrote: Thanks for merging. It'd be really cool if you released a new version - 0.3.4 I think :-)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

woodruffw commented 1 year ago

Cut with 0.3.4. Thanks @charles2910!