search

trailofbits / polytracker

An LLVM-based instrumentation tool for universal taint tracking, dataflow analysis, and tracing.
Apache License 2.0
517 stars 47 forks source link

Remove exclusion filters from mypy.ini as it is not needed anymore #6513

Closed hbrodin closed 1 year ago

hbrodin commented 1 year ago

Only include suppressions and configuration for that is currently needed.

Fixes #6507

hbrodin commented 1 year ago

Does https://github.com/trailofbits/polytracker/blob/master/.github/workflows/dockerimage.yml somehow use this ini file or does this only apply to local runs? I think this is the relevant line of the Action job :

mypy --python-version ${{ matrix.python-version }} --ignore-missing-imports polytracker tests

My understanding is that it picks up mypy.ini from the dir and use it for configuration.

kaoudis commented 1 year ago

My understanding is that it picks up mypy.ini from the dir and use it for configuration.

yeah that makes sense - looks like it implicitly picks it up by default https://mypy.readthedocs.io/en/stable/config_file.html but one can override with --config-file, just not required by default