Enhance github actions - Githubissues

trailofbits / semgrep-rules

Semgrep queries developed by Trail of Bits.

GNU Affero General Public License v3.0

330 stars 32 forks source link

Enhance github actions #20

Closed GrosQuildu closed 8 months ago

GrosQuildu commented 1 year ago

run semgrep's linters with semgrep --validate
run checks for metadata
maybe run performance tests
maybe make use of https://github.com/returntocorp/semgrep-rules-test-action/

Vasco-jofra commented 1 year ago

I also noticed that the semgrep --test workflow is incorrect.

https://github.com/trailofbits/semgrep-rules/blob/f0dfa238a0c8aed1ae5672cdfadb43f387462595/.github/workflows/semgrep-rules-test.yml#L27-L29

It does semgrep --test rust/, but the folder is called rs/. We should probably just do semgrep --test / to test everything, or use an existing action as you suggest.

GrosQuildu commented 8 months ago

Tests fixed in e3016e62253eacdbb0c74cc4f593d7d867742519

GrosQuildu commented 8 months ago

Resolved in https://github.com/trailofbits/semgrep-rules/pull/40