search

trailofbits / sienna-locomotive

A user-friendly fuzzing and crash triage tool for Windows
https://blog.trailofbits.com/user-friendly-fuzzing-with-sienna-locomotive
GNU Affero General Public License v3.0
131 stars 24 forks source link

The GUI should close server windows that die #354

Closed woodruffw closed 6 years ago

woodruffw commented 6 years ago

If the server dies for whatever reason during a GUI session, the GUI should close the PowerShell window that the (dead) server was running in.

This should be configurable, since it's nice to have the dead server's window around for debugging. But for the end user, it'll just be an eyesore.

ehennenfent commented 6 years ago

This is more difficult than it seems at first glance. In order to get the server to pop out in a new window, we have to start two nested instances of powershell, which will make getting the PID for the powershell session containing the server tricky to get.

woodruffw commented 6 years ago

I was able to cheese it by just removing the -NoExit argument from the ps_run invocation programmatically. I'll push a PR up in a moment that has the changes.