Closed rfgil closed 1 year ago
Thanks @rfgil! This looks reasonable to me.
Would you mind adding some tests as well?
Would you mind adding some tests as well?
@woodruffw Sure, just added a spec with the SPF record above. Let me know if it's as you expected. Thanks!
Yep, LGTM. Thanks @rfgil!
Hi! Thank you for this gem.
I noticed the gem is failing to parse the following SPF Record:
v=spf1 include:%{ir}.%{v}.%{d}.spf.has.pphosted.com -all
:This is because the parser is not expecting the
%{v}
macro, which is valid according to the documentation: https://datatracker.ietf.org/doc/html/rfc7208#section-7.4.Thus, this PR adds the missing
v
as a validmacro_letter
.