SPF record type discontinued

trailofbits / spf-query

Ruby SPF Parser

MIT License

29 stars 15 forks source link

SPF record type discontinued #3

Closed nsoufr closed 8 years ago

nsoufr commented 8 years ago

Heys guys,

First of all, thank you for this incredible gem. It saved a lot of our time.

I've noticed that spf-query checks for SPF type records in https://github.com/trailofbits/spf-query/blob/master/lib/spf/query/query.rb#L23.

Since SPF record type was discontinued at RFC 7208, I think would a great idea to remove this verification or provide an alternative that allows us to skip it.

that make sense?

postmodern commented 8 years ago

I would like to keep it around for maximum coverage. We could move it to the bottom, as _spf.example.com is now the defacto location for SPF records.

nsoufr commented 8 years ago

@postmodern good idea. Just changing order works perfectly too.

I've opened two PR's with both skip and reorder approach. Thoughts?

postmodern commented 8 years ago

Merged. Adding options to enable/disable checking for SPF records in various places could be a different feature later on.

nsoufr commented 8 years ago

Awesome. Thanks ;)

nsoufr commented 8 years ago

bump the version ;) please?