search

trailofbits / spf-query

Ruby SPF Parser
MIT License
29 stars 15 forks source link

Normalize mechanism value #9

Open evserykh opened 6 years ago

postmodern commented 5 years ago

Could you explain the purpose of this change?

postmodern commented 5 years ago

Could we also omit empty strings in the Transform section?

evserykh commented 5 years ago

@postmodern I don't remember exactly why I've created the PR. It's likely I've got empty string or nil as a result and I was forced to check the both cases, so I've decided to simplify that.

postmodern commented 5 years ago

Hmm I will have to double check the RFC is empty strings have a special meaning. If not, then we can map "" => nil.

evserykh commented 5 years ago

that would be great 👍