Scrollbar fix - Githubissues

trailofbits / testing-handbook

Trail of Bits Testing Handbook

https://appsec.guide/

Creative Commons Attribution 4.0 International

36 stars 4 forks source link

Scrollbar fix #31

Closed ahpaleus closed 2 months ago

ahpaleus commented 2 months ago

Before:

After (only after hovering the mouse over):

github-actions[bot] commented 2 months ago

PR Preview Action v1.4.7 :---: Preview removed because the pull request was closed. 2024-04-25 13:19 UTC

ahpaleus commented 2 months ago

@elopez take a look, merge if it's ok

elopez commented 2 months ago

This doesn't seem to have any effect on Firefox (I guess it's expected, considering that the PR uses nonstandard webkit extensions).

Can we add something with the standard properties so it looks a bit better there as well?

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scrollbars_styling

https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar#adding_a_fallback_for_scrollbar_styles

ahpaleus commented 2 months ago

This doesn't seem to have any effect on Firefox (I guess it's expected, considering that the PR uses nonstandard webkit extensions).

Can we add something with the standard properties so it looks a bit better there as well?

https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_scrollbars_styling

https://developer.mozilla.org/en-US/docs/Web/CSS/::-webkit-scrollbar#adding_a_fallback_for_scrollbar_styles

Thanks! @supports selector(::-webkit-scrollbar) seems to be unsupported in Hugo but I will try to find a workaround :-)

ahpaleus commented 2 months ago

@elopez I am not sure if it is the best way to achieve this (https://github.com/trailofbits/testing-handbook/pull/31/commits/b9cba8201e4fe8f0e290b298deca7a6d92a868a1), but you can see Firefox/Safari/Chrome: