trailofbits / tlslib.py

MVP for updated PEP 543 proposal
https://trailofbits.github.io/tlslib.py/
Apache License 2.0
9 stars 0 forks source link

Replace `time.sleep()` in tests with a more robust retrying logic. #20

Closed facutuesca closed 7 months ago

facutuesca commented 7 months ago

Using this retrying logic might save us some test flakiness in the future

woodruffw commented 7 months ago

My only hesitation here is in upstreamability -- our tests currently avoid pytest because we want to make this straightforward to upstream into CPython itself. Maybe we can carve out the retrying helper here and include it in _utils.py?

facutuesca commented 7 months ago

My only hesitation here is in upstreamability -- our tests currently avoid pytest because we want to make this straightforward to upstream into CPython itself. Maybe we can carve out the retrying helper here and include it in _utils.py?

@woodruffw done! we now have our own retrying helper