search

trailofbits / uthenticode

A cross-platform library for verifying Authenticode signatures
https://trailofbits.github.io/uthenticode/
MIT License
133 stars 33 forks source link

Adjust README.md so that CMake easily use vcpkg-installed packages #74

Closed ret2libc closed 1 year ago

ret2libc commented 1 year ago

Provide instructions similar to those in https://vcpkg.io/en/getting-started.html .

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ret2libc commented 1 year ago

I wasn't actually able to install things with vcpkg install pe-parse. I had to run vcpkg install, but even then CMake was not actually able to discover the libraries needed.

By using CMAKE_TOOLCHAIN_FILE=<vcpkg-path>/scripts/buildsystems/vcpkg.cmake cmake automatically install the deps and adds the right paths to use those libs.

woodruffw commented 1 year ago

Thanks for this!

Yeah, the steps before were very implicit: they assumed that the user had vcpkg configured environmentally, which isn't how vcpkg's own docs encourage things. This is much better!

woodruffw commented 1 year ago

Judiciously ignoring the CLA for an employee.