search

trailofbits / vscode-weaudit

Create code bookmarks and code highlights with a click.
https://marketplace.visualstudio.com/items?itemName=trailofbits.weaudit
GNU General Public License v3.0
169 stars 16 forks source link

feat: adds command to mark region as reviewed #21

Closed mathewmeconry closed 4 months ago

mathewmeconry commented 5 months ago

This pull adds the functionality to mark a region as reviewed. It merges overlapping regions, ignores regions that are already marked by one that is bigger, and removes the entry if the exact region is selected.

It doesn't update the daily log. Maybe a feature could be added so that you get an exact line count for the daily log but this would break existing logs.

The new shortcut defined isn't set in stone but made sense to me. Idk if this combination actually works for macOS.

Resolves: Issue #20 (had the same pain in the past days)

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

fcasal commented 5 months ago

Hi @mathewmeconry , thanks for the contribution! I will review this by the end of next week

mathewmeconry commented 5 months ago

Hey @fcasal Thanks for the review. I adapted the pull to the changes you requested or left a response for your question.

mathewmeconry commented 5 months ago

hey @fcasal I added your requested changes. Please check it again

fcasal commented 5 months ago

hey @mathewmeconry, thanks for the great work. I'll review your new changes by the end of the week

fcasal commented 4 months ago

@mathewmeconry thanks again for the PR, I think the UX behavior is great how it currently is. One final thing is to add the feature to the readme. If you'd like to do that feel free, otherwise I can also do it and record a small gif myself.

mathewmeconry commented 4 months ago

@fcasal added your last comments. Could you add it to the readme? Screenrecording regions on wayland is a pain...