search

trailofbits / vscode-weaudit

Create code bookmarks and code highlights with a click.
https://marketplace.visualstudio.com/items?itemName=trailofbits.weaudit
GNU General Public License v3.0
175 stars 17 forks source link

Add support for ignoring files #54

Open alxshine opened 1 month ago

alxshine commented 1 month ago

Hello hello :wave: :blush:

This PR implements the feature requested in #32.

The handling of ignoredFiles is very closely modeled on the handling of auditedFiles.

The checkIfAllSiblingFilesAreAudited now checks if the candidate file is either audited or ignored, causing a directory full of ignored files to be seen as audited. This seemed like the simplest way to integrated it into the existing functionality.

In the explorer view, ignored files are indicated in the same color as gitignored files.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

fcasal commented 1 month ago

Hi @alxshine, I haven't yet reviewed this PR because we want to merge a big refactor of the codebase https://github.com/trailofbits/vscode-weaudit/pull/48 first. As a high level comment about the PR I think I would like to handle ignored files using a .weauditignore file -- in a way that if you mark a file as ignored, it would be also added to the .weauditignore file. In that file, you could also specify folders or globing behaviour like you can in .gitignore