search

trailofbits / vscode-weaudit

Create code bookmarks and code highlights with a click.
https://marketplace.visualstudio.com/items?itemName=trailofbits.weaudit
GNU General Public License v3.0
169 stars 16 forks source link

Support for opening GitLab issues #6

Closed tmr232 closed 4 months ago

tmr232 commented 6 months ago

Can you add support for opening GitLab issues, if the repo URL points to Gitlab?

The URL query parameters need to be named differently for Gitlab.

Thank you!

fcasal commented 6 months ago

Hello @tmr232, this should be easily doable.

To implement this, I imagine having a toggleable configuration github/gitlab on the extension settings, and then it would use the proper query parameters accordingly. Would that be in line with your use case?

tmr232 commented 6 months ago

@fcasal Thanks for the quick reply!

Yes, a toggleable per-project configuration in the extension settings sounds like a great solution.

Falcon9901 commented 6 months ago

Thanks for your helpful extension, Now while you're adding Gitlab support please make sure it will support self-hosted (on-premises) GitLab instances by accepting a Gitlab URL as a parameter in extension settings. This would enable the extension to work with both the cloud-hosted GitLab.com and self-hosted GitLab instances running on-premises.

fcasal commented 4 months ago

Hi @tmr232 @Falcon9901 , I've implemented this in #35. No configuration option is needed, as it works by checking whether the URL you are opening the issues for is on github.com.

Let me know if this solves this limitation for your use case!