search

trailsjs / generator-trails-old

:package: Trails Generator.
Other
6 stars 8 forks source link

tests report as passing when they actually fail #22

Closed tjwebb closed 8 years ago

tjwebb commented 8 years ago

https://travis-ci.org/trailsjs/generator-trails/jobs/100739885#L1007

jaumard commented 8 years ago

It's because of isparta, we use this command babel-node node_modules/.bin/isparta cover _mocha and if tests failed coverage is running anyway, so maybe Travis doesn't detect failing tests cause coverage doesn't failed. I disable isparta and travis detect failing tests https://travis-ci.org/trailsjs/generator-trails/builds/102075702

So for now I disable isparta to have real test unit. But need deep searching to resolve this if we want coverage. It's on this PR https://github.com/trailsjs/generator-trails/pull/25

jaumard commented 8 years ago

Fix on master