search

trailsjs / generator-trails-old

:package: Trails Generator.
Other
6 stars 8 forks source link

Windows problem #66

Open jaumard opened 7 years ago

jaumard commented 7 years ago

Don't know why but currently tests are failing on windows

gliwka commented 7 years ago

I'll check it out.

gliwka commented 7 years ago

The important line seems to be: https://ci.appveyor.com/project/trailsjs/generator-trails/build/1.0.43/job/6868biw74pn4m6u8#L1128

It fails to shutdown the trails app, that's why also the next test is failing with EADDRINUSE.

info: Shutting down... (node:576) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'removeAllListeners' of undefine

Unfortunately I wasn't able to reproduce this on my Windows 10 VM, but i'll keep looking into it.

gliwka commented 7 years ago

Okay, i was able to reproduce it. The test only fails, when you redirect the test output to a textfile.

Edit: This affects all operating systems.

The test fails, because trails crashes while launching the repl (see trailsjs/trails#222). This has already been fixed in trailpack-repl (https://github.com/trailsjs/trailpack-repl/pull/38). Now we just would need to bump the version numbers in https://github.com/trailsjs/trails/blob/master/archetype/package.json.

I'll open a PR on the trails repo, since this also is neccesary for the docker issue.

gliwka commented 7 years ago

@jaumard There is already a PR which fixed the trailpack-repl version. You just need to merge this: https://github.com/trailsjs/trails/pull/239 to fix this bug.

jaumard commented 7 years ago

Ho ok ! Thanks to dig in it @gliwka ! :D I'll look at this PR it finally was a simple repl bug lol