sails.getBaseURL() is deprecated.

[tom-sherman]

As getBaseURL() is being deprecated in Sails v1.0, there should be implemented a more elegant way to define this.

The offending bit in passport.js:

var baseUrl = sails.getBaseurl();

switch (protocol) {
  case 'oauth':
  case 'oauth2':
    options.callbackURL = url.resolve(baseUrl, callback);
    break;

  case 'openid':
    options.returnURL = url.resolve(baseUrl, callback);
    options.realm     = baseUrl;
    options.profile   = true;
    break;
}

---

Reference:

There is no reliable, cross-platform way to automatically detect the external URL of a running Sails app (or any other Node app). In mission-critical situations, you are advised to pre-determine the URL and save it in a custom environment-dependent configuration value (e.g. sails.config.appUrl) that you can reference elsewhere in the app.

[tjwebb]

There is no reliable, cross-platform way to automatically detect the external URL of a running Sails app

So, what should we do?

[tom-sherman]

Could look for a few configuration values before using this deprecated method. Maybe then add an error message to advise to set one up?

[scott-wyatt]

I agree, I think that this should be set through an environment variable in future releases.

[Garland220]

This will fail if 'sails.config.appUrl' is undefined.

I would suggest adding a check for undefined as well:

      var baseUrl = '';
      if (sails.config.appUrl && sails.config.appUrl !== null) {
        baseUrl = sails.config.appUrl;
      }
      else {
        sails.log.warn('Please add "appUrl" configuration value.');
        baseUrl = sails.getBaseurl();
      }

155

[tom-sherman]

@Garland220 That's strange, I specifically remember testing for this case and it produced the expected result (a warning).

[TheSinding]

Is there a fix for this issue?

[tom-sherman]

@TheSinding Which issue are you referring to? Both my solution and the hotfix have been merged into master

[0aps]

@tom-sherman he probably says that because your solution is not yet publish into npm.

[TheSinding]

Sorry I didnt answer until now @tom-sherman. Yeah @0aps is properly correct, when I tried with Sail 1.0 and the auth lib, I kept getting an sails.baseUrl() error..

[abalad]

Same here

[amoritan]

(+1) It would be great if the npm package was updated with the latest release available on GitHub.

[lauragift21]

Is there a fix for this error?

[michaelfahmy]

Any fix?!!! It's too long since this issue has been opened. Please update the package!

[tjwebb]

see:

• https://github.com/trailsjs/sails-auth/issues/126
• https://github.com/trailsjs/sails-auth/issues/118