Change get /logout to post /logout

trailsjs / sails-auth

Passport-based User Authentication system for sails.js applications. Designed to work well with the sails-permissions module.

https://www.npmjs.org/package/sails-auth

MIT License

265 stars 141 forks source link

Change get /logout to post /logout #94

Closed johnbailon closed 8 years ago

johnbailon commented 8 years ago

For minor security purposes, allow /logout only via POST instead of GET.

tjwebb commented 8 years ago

tests fail?

johnbailon commented 8 years ago

@tjwebb not sure why it would fail, it's a one-word change.

tjwebb commented 8 years ago

@johnbailon yea the tests fail because there are logout unit tests that rely on the previous behavior. Typical practice is to update the tests with your change so that the test suite remains current.