search

trailsjs / trailpack-express

:package: Express Trailpack
MIT License
12 stars 15 forks source link

host config for heroku deployemnts #44

Closed konstantinzolotarev closed 8 years ago

konstantinzolotarev commented 8 years ago

Right now when you try to deploy new Trails application to heroku it will fail (even without trailpack-repl with this error: Error R10 (Boot timeout) -> Web process failed to bind to $PORT within 60 seconds of launch

This fix will correctly bind trails application to heroku instance

jaumard commented 8 years ago

It doesn't append with hapi ? By default it listen to 0.0.0.0 ?

konstantinzolotarev commented 8 years ago

@jaumard same issue with hapi PR here: https://github.com/trailsjs/trailpack-hapi/pull/109

jaumard commented 8 years ago

Cool :) thanks @konstantinzolotarev !

scott-wyatt commented 8 years ago

Nice! Is this deployed to NPM?

konstantinzolotarev commented 8 years ago

@scott-wyatt not really sure.

jaumard commented 8 years ago

@scott-wyatt @konstantinzolotarev nope I just merge :) feel free to create a new tag to deploy it on npm (don't forget to increment the package version first) same for hapi

scott-wyatt commented 8 years ago

I should know this, but who has access to this on NPM?

jaumard commented 8 years ago

@scott-wyatt it's not on npm it on github :) you create a tag git tag vX.X.X and push it git push --tags (so everyone on the trails team) and then TravisCI will publish it on npm automatically if build is green

konstantinzolotarev commented 8 years ago

@jaumard @scott-wyatt it's really easier to use npm version patch git push --tags

scott-wyatt commented 8 years ago

I kind of feel akward pusing to NPM as me. Who's the author of the repo?

jaumard commented 8 years ago

But you'll not publish as yourself :) you'll publish as Trails no one will know it's you that publish this version. BTW I'm the author, I release a lot of version of Trails repos and you didn't know it was me ;) lol

scott-wyatt commented 8 years ago

Okay, I used npm version patch -m "Upgrade to %s for host config" && git push --tags

jaumard commented 8 years ago

Cool ! you also need a git push to push on master the new package version or it will stay to previous one

scott-wyatt commented 8 years ago

@jaumard Executed git push :-) Thanks! That's my first time pushing a repo I didn't start :-p

jaumard commented 8 years ago

Ha ha congrats @scott-wyatt ! Fully deploy https://www.npmjs.com/package/trailpack-express :) All trails repo work like this ! I love this process, that allow all maintainers to publish new version too and not one person ^^