search

trailsjs / trails

:evergreen_tree: Modern Web Application Framework for Node.js.
http://trailsjs.io
Other
1.66k stars 70 forks source link

lib.Pathfinder Lifecycle #isComplete should execute in under 5ms #243

Closed catrielmuller closed 7 years ago

catrielmuller commented 8 years ago

Issue Description

In some cases the travis ci test breaks cos this test fail. Example: https://travis-ci.org/trailsjs/trails/jobs/165140454

I do not see the advantage of measuring performance on a server that does not have the resources dedicated to the test. This means that in some occasions (almost always) the test fails because the server is more saturated. I propose that we increase the time of the tests (5ms to 15ms and 2ms to 6ms), or simply remove these tests.

Environment

jaumard commented 8 years ago

I think those tests are nice to have but should be tested locally only not under CI witch is not stable.

tjwebb commented 8 years ago

Yea, hosted CI won't be a reliable way to test this. Perhaps we can keep these tests, but separate them into a separate test suite. e.g., npm run performance-tests?

catrielmuller commented 8 years ago

Perfect let me do that