[fix] lib tests - Githubissues

trailsjs / trails

:evergreen_tree: Modern Web Application Framework for Node.js.

http://trailsjs.io

Other

1.67k stars 70 forks source link

[fix] lib tests #306

Closed scott-wyatt closed 6 years ago

scott-wyatt commented 6 years ago

strict checking on immutable being a boolean
passes config to validateConfig
adds scott wyatt to list of contributors.
finishes lib configuration tests
exception: non-virtual setters are still being allowed for some reason.

scott-wyatt commented 6 years ago

this is really difficult. I get the value, but it's the last 2 test, before v3 can go to quorum for release. Is this necessary for 3.0.0? I don't see it being a breaking change.

scott-wyatt commented 6 years ago

All said @jaumard, thoughts on merging this into the v3 pr? We can revert it later, but it's 3 tests closer than it was :-) and some silly nano seconds faster to boot.

jaumard commented 6 years ago

Ok for me to merge :)

scott-wyatt commented 6 years ago

@tjwebb I'm going to merge this into your PR for the time being, reverting shouldn't be bad if it's not complete with your goals. I'll open a new PR with more coverage for resolvers.