trailsroc / map-data

Map data for the #TrailsRoc app
https://trailsroc.org/trailsroc-the-app
Creative Commons Zero v1.0 Universal
1 stars 0 forks source link

Audit parks/trails in the city #12

Open mmertsock opened 4 years ago

mmertsock commented 4 years ago

The county and suburban areas get all the attention. See what’s in the city that we can add

mcbeth commented 4 years ago

Unless you're going after this one, I'm going to target this trail next

mmertsock commented 4 years ago

Yeah, I was going to look at this next. I have some data already and have run El Camino myself, etc.

mcbeth commented 4 years ago

I don't think your changes have been updated put on Mapbox (I can't find El Camino). I think because they're changes all over the place, our best bet is to rebuild the dataset and tileset from scratch again (using rebuild.sh). Since Isaac Gordon is merged, I'm happy to take a pause from data creation so we can get all our ducks in a row again.

mmertsock commented 4 years ago

After I merged my PR, I generated a new combined geojson file with all data, and uploaded it as a new prod-v1-build1 dataset. That's why there are two such datasets: I was leveraging the new capability of the iOS app to select the most recently modified dataset with that name, and planned to delete the older dataset after a couple days. For the tileset, I used the Replace function in Mapbox Studio to update the existing prod-v1-build1 tileset (and thus update the styles themselves) with new combined geojson file.

I'm pretty sure the point of confusion is the two prod-v1-build1 datasets: you added the Isaac Gordon data to the older dataset which doesn't have my El Camino data, and presumably updated the tileset using that?

Generally speaking, my plan going forward is to always regenerate a new geojson file from scratch and use that upload a brand new dataset/replace the tileset, to ensure the data in Mapbox always matches what's in this repo. I'm not currently using rebuild.sh itself since I don't have its dependencies set up, but effectively I'm doing the same thing by using my recent tweak to make_geojson.rb. If we both follow that general practice after merging PRs, then we shouldn't risk Mapbox getting out of sync.

Anyway, I'm happy to get everything synced up tonight if you don't get to it before me.

mmertsock commented 4 years ago

Mapbox datasets/tilesets/styles are all synced up now