trainline / consul-deployment-agent

Cross-platform deployment agent for Environment Manager
Other
1 stars 0 forks source link

Safely handle invalid healthchecks.yml #26

Closed duncanhall closed 7 years ago

duncanhall commented 7 years ago

Invalid healthchecks.yml files cause the agent to raise an exception and prevent installation from proceeding. In the case of deregistering and invalid yml file from a previous deployment, this can prevent any future deployments from succeeding.

This change catches only validation errors and will skip check registration/deregistration in these cases, allowing "fixing forward" deployments to succeed while still preventing installations that might result in an unknown state.