search

trainline / react-skeletor

Skeleton loading for React
https://trainline.github.io/react-skeletor/
Other
554 stars 27 forks source link

Make prop-types declaration file a dependency #14

Open thchia opened 6 years ago

thchia commented 6 years ago

Description

Moved @types/prop-types from devDependencies to dependencies.

Addressed issue #15

TypeScript consumers of the library need this package due to the type export in utils.d.ts. Currently as it is a devDependency it is not included in a normal install and results in TS compiler errors.

I have followed the official suggestion here of including it as a regular dependency.

Our package exposes declarations from each of those, so any user of our [browserify-typescript-extension - react-skeletor] package needs to have these dependencies as well. For that reason, we used "dependencies" and not "devDependencies", because otherwise our consumers would have needed to manually install those packages.

alex3165 commented 6 years ago

@thchia Thanks for the PR, can you also move @types/react, the same should apply to this dependency then