traitecoevo / APCalign

R package for accessing, matching and updating species names of Australian flora
https://traitecoevo.github.io/APCalign/
Other
4 stars 6 forks source link

make input names consistent across main functions #106

Closed dfalster closed 1 year ago

dfalster commented 1 year ago

The first argument for align_taxa is called original_name, while for create_taxonomic_update_lookup it's taxa.

Argument name need to be consistent across the main functions: align_taxa is called , create_taxonomic_update_lookup and update_taxonomy, also with outputs

For this argument I suggest original_name is better.

ehwenk commented 1 year ago

Some variable names to consider renaming / make more consistent:

ehwenk commented 1 year ago

In terms of input parameters for the functions, I think they are largely consistent - the exception is that the term original_name is used in align_taxa versus taxa in match_taxa and create_taxonomic_update_lookup. I can't decide if I think these should be the same term or not.