traitecoevo / APCalign

R package for accessing, matching and updating species names of Australian flora
https://traitecoevo.github.io/APCalign/
Other
4 stars 6 forks source link

Problem with recent changes to `identifiers` #114

Closed ehwenk closed 1 year ago

ehwenk commented 1 year ago

In commit https://github.com/traitecoevo/APCalign/commit/8aabbc865da6efc86f9db67394b40f0fb72c32e5 there was an error introduced to all matches where an ifelse() statement was included to created the aligned_name. I think this occurred because the two identifier strings created (identifier_string and identifier_string2) were fixed values, rather than columns within taxa$tocheck and therefore, for other values (e.g. canonicalName) being included in the pasted together strings for aligned name were always the first values from, for instance, resources$genera_all2$canonicalName[ii], rather than the appropriate line of resources$genera_all2$canonicalName[ii].

ehwenk commented 1 year ago

closed with https://github.com/traitecoevo/APCalign/commit/d0de483dce5d00684a7f4ef25f0f87005a814c69