search

traitecoevo / APD

The Australian Plant Traits Dictionary
https://traitecoevo.github.io/APD/
4 stars 2 forks source link

Fix typo in GIFT equivalent trait #24

Closed Rekyt closed 4 months ago

Rekyt commented 4 months ago

Hi @ehwenk and @dfalster 👋 I'm working with the raw data file APD_traits_input.csv for the sake of simplicity rather than the RDF files (maybe I shouldn't?😅 ) I noticed a typo in one trait with GIFT.

So I'm proposing to correct it.

ehwenk commented 4 months ago

@Reykt Thank you for letting us know about this error. I have moved this change to this branch - https://github.com/traitecoevo/APD/commit/0e3d720ff2125b4fda9f4c62407cdf247b4d85ad - to avoid conflicts when we merge two branches that both have edits to APD_traits_input.csv.

I'll leave this pull request open for now, but close it when we merge in the other branch, hopefully in the coming month.

dfalster commented 4 months ago

Thanks for your inputs @Rekyt !

Rekyt commented 4 months ago

Just for the sake of completeness I've tried to match all traits that would have non-matching square brackets using the following expression:

raw_apd |>
  select(contains("LEDA"), contains("BROT"), contains("TOP"), contains("GIFT"),
         contains("BIEN"), contains("TRY")) |>
  filter(if_any(everything(), \(x) x != "" & !grepl("\\[[^][]*]", x)))

And the good news is that apart from this one in GIFT, I found no other! So, in this regard, the file seems correct.

dfalster commented 4 months ago

Closing as these changes have been addressed via #26