Unit conversion broken where multiple units exist per dataset

jamesrlawson commented 8 years ago

See dataset_093 plant_height_max

e.g. Haemodorum spicatum value in raw data is 200 with units cm. Remains at 200 with units m in processed data.

Not yet sure if this is an isolated case, will update.

dfalster commented 8 years ago

@jamesrlawson -- The above commits fix the issues with dataset_093 and provide infrastructure for applying a similar fix elsewhere. I also added a new test to check whether the Traits section in metadata.yml has duplicates. One reason there may be duplicates was to handle multiple units, but this is not how we're handling things now. So can you check through the following datasets to see why duplicates exist and if it's because of mutliple units, apply a similar fix to that applied above?

➜  austraits git:(master) ./test_all.R 
tests//test-setup.R#97:1 [failure] Setup. ../data/dataset_008/metadata.yml - should not contain: vegetation type
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_021/metadata.yml: Traits - not unique: specific_leaf_area
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_028/metadata.yml: Traits - not unique: wood_density
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_032/metadata.yml: Traits - not unique: specific_leaf_area
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_A/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_B/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_C/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_D/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_E/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_F/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_G/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_H/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_I/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_057_J/metadata.yml: Traits - not unique: leaf_dry_matter_content
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_061/metadata.yml: Traits - not unique: wood_density
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_066/metadata.yml: Traits - not unique: leaf_phenology
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_070/metadata.yml: Traits - not unique: specific_leaf_area
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_092/metadata.yml: Traits - not unique: leaf_length_max, leaf_length_min, leaf_width_max, leaf_width_min, plant_height_max, plant_height_min
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_105/metadata.yml: Traits - not unique: specific_leaf_area
tests//test-setup.R#81:1 [failure] Setup. ../data/dataset_114/metadata.yml - should not contain: lookup
tests//test-setup.R#87:1 [failure] Setup. ../data/dataset_114/metadata.yml - should not contain: special_life_form, special_growth_form, flower_colour, height_class, leaf_arrangement, leaf_margin, fruiting, propagation, introduced
tests//test-setup.R#88:1 [failure] Setup. ../data/dataset_116/metadata.yml: Traits - not unique: specific_leaf_area

dfalster commented 8 years ago

Remaining items appear in #58

traitecoevo / austraits.build

Unit conversion broken where multiple units exist per dataset #54