Open yangsophieee opened 1 year ago
Patch and project coverage have no change.
Comparison is base (
a311f6c
) 80.20% compared to head (1a0b1b5
) 80.20%.:exclamation: Current head 1a0b1b5 differs from pull request most recent head 3c2a64f. Consider uploading reports for the commit 3c2a64f to get more accurate results
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
- Just checking that Ks is
sapwood_specific_conductivity
, notstem_specific_conductivity
? From text: "Kfinal was normalized by the pressure gradient, sapwood area, and stem length to obtain initial and final xylem-specific hydraulic conductivity (Ks, kg m−1 s−1 MPa−1)."
yes, correct
- Do we have traits for Ψleaf at 50% of maximum stomatal conductance ("Early decline of stomatal conductance; proxy of Ψleaf at which stomata initiate closure") and 10% of maximum stomatal conductance ("Maximum water stress while still maintaining minimal photosynthesis; proxy of complete stomatal closure")?
We don't at this point, but there are several studies with this trait. I'll add it to the additional traits section at the bottom
- What about Cbranch ('Amount of releasable water of living cells as xylem tension increases') and VIGR ('Stem volume index growth rate, a surrogate of plant growth rate')?
So... it was just suggested to us that we add capacitance, and I have, but I'm now worried I have the wrong units (lots of options) because my units aren't what they have here. We don't have VIGR
- I'm a bit confused with the methods for Amax, it says "Leaf net carbon assimilation rate (An)... were measured by placing the leaf into a 2 × 3 cm cuvette supplied with saturating light (1,500 μmol m−2 s−1) and ambient CO2 concentration (420 μmol mol−1)." If it's ambient CO2 then that's not Amax right? But they say it was for An not Amax. In the section before it says the following but I'm not sure what it means: "During this phase, leaf gas exchange characteristics and corresponding leaf water potential (Ψleaf, MPa) were measured periodically until positive net photosynthesis (Amax, μmol m−2 s−1) was no longer detectable."
I think there are two tricky bits here - it is Asat, not Amax - I'm surprised they call it Amax. Also, if you look at Table 2, they define it as "Maximum carbon assimilation rate under well-watered conditions". So I think that is the mean value they provide.
So... it was just suggested to us that we add capacitance, and I have, but I'm now worried I have the wrong units (lots of options) because my units aren't what they have here.
Looking back at the methods: "Branch RWC (RWCbranch, %) at each measurement period was calculated and plotted against Psi stem. Cbranch was estimated as the slope of the second linear portion of the water release curve, expressed as DeltaRWC/DeltaPsi (RWC MPa-1)."
Also I used ausflora
to check taxonomic updates and I'm wondering if Acmena smithii needs an update to Syzygium smithii?
That taxonomic change should be automatic - when I review studies I look at the reports and confirm that all taxa are aligned to species - if the name doesn't automatically update, this wouldn't happen
I think there are two tricky bits here - it is Asat, not Amax - I'm surprised they call it Amax. Also, if you look at Table 2, they define it as "Maximum carbon assimilation rate under well-watered conditions". So I think that is the mean value they provide.
I've changed replicates to 4 because "Four individuals of each species were assigned to a well-watered treatment and were watered daily over the experimental period."
Study investigating variation in key hydraulic and carbon economy traits of 12 woody species in Australia across a broad climatic gradient, using a common garden approach.
Questions for review:
life_stage
is -- they grew plants from seed, seedlings were transplanted in 2016 and then grown and measured until maybe May 2017? So one or two years old. Is it just juvenile?water_potential_12percent_lost_conductivity
? I can only find 50 and 88.sapwood_specific_conductivity
, notstem_specific_conductivity
? From text: "Kfinal was normalized by the pressure gradient, sapwood area, and stem length to obtain initial and final xylem-specific hydraulic conductivity (Ks, kg m−1 s−1 MPa−1)."sapwood_specific_conductivity
tosapwood_specific_hydraulic_conductivity
be updated when merged or do we need to do that here?