search

traitecoevo / austraits.build

Source for AusTraits
Other
16 stars 2 forks source link

Regenerate traits.yml from APD #727

Closed ehwenk closed 1 year ago

ehwenk commented 1 year ago
ehwenk commented 1 year ago

@dfalster I've now updated traits.yml to match the APD v1.0.0

Where should we archive the script? It draws upon the 2 data files from APD repository (APD_traits.csv & APD_categorical_values.csv), then builds a file that goes into austraits.build repository.

Noting there are 2 manual tweaks required. 1) replacing ''' (3 single quotes) with ' (1 single quote) ; and 2) removing 3 instances of allowed_values_levels: {} that are inserted for the 3 categorical traits that don't have set values (fruiting_time, flowering_time, recruitment_time)

dfalster commented 1 year ago

Please add the code in a file within scripts and I'll review workflow from there

dfalster commented 1 year ago

@ehwenk I think can be merged now

dfalster commented 1 year ago

Actually hold off for now. Just thought of one more change to make

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c28b9f) 80.20% compared to head (fa3a006) 80.20%.

:exclamation: Current head fa3a006 differs from pull request most recent head 4e6647d. Consider uploading reports for the commit 4e6647d to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #727 +/- ## ======================================== Coverage 80.20% 80.20% ======================================== Files 7 7 Lines 1531 1531 ======================================== Hits 1228 1228 Misses 303 303 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.