search

traitecoevo / austraits.build

Source for AusTraits
Other
16 stars 2 forks source link

Error entity type (wide data) #738

Closed dfalster closed 1 year ago

dfalster commented 1 year ago

Solves first issue raised in #725, that entity_type and value_type are not being successfully read from a column of data.

dfalster commented 1 year ago

@ehwenk I suggest we address the other part of #725 issue (for long data) via a seperate branch and PR

ehwenk commented 1 year ago

@ehwenk I suggest we address the other part of #725 issue (for long data) via a seperate branch and PR

sure.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 :tada:

Comparison is base (5fc970a) 80.20% compared to head (e151a3d) 80.24%.

:exclamation: Current head e151a3d differs from pull request most recent head c099937. Consider uploading reports for the commit c099937 to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #738 +/- ## =========================================== + Coverage 80.20% 80.24% +0.03% =========================================== Files 7 7 Lines 1531 1534 +3 =========================================== + Hits 1228 1231 +3 Misses 303 303 ``` | [Impacted Files](https://app.codecov.io/gh/traitecoevo/austraits.build/pull/738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traitecoevo) | Coverage Δ | | |---|---|---| | [R/process.R](https://app.codecov.io/gh/traitecoevo/austraits.build/pull/738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=traitecoevo#diff-Ui9wcm9jZXNzLlI=) | `91.85% <100.00%> (+0.03%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dfalster commented 1 year ago

Hi Lizzy,

Sorry but I don't understand what you were asking in your last message. You refer several times to "this" branch, but I suspect some of the this actually meant the one with the link?

In any case, perhaps two seperate commits is best?

ehwenk commented 1 year ago

Two commits is fine. There is a second branch where I made changes to metadata files and which had the initial changes for fixing entity_type that are now superceded. The other branch is: https://github.com/traitecoevo/austraits.build/tree/fix-entity_type-value_type-units-not-reading-in .