move k_I into strategy - Githubissues

traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:

https://traitecoevo.github.io/plant

53 stars 20 forks source link

move k_I into strategy #229

Closed rafaqz closed 3 years ago

rafaqz commented 4 years ago

currently defined in parameters

dfalster commented 4 years ago

Yes. This should be part of the plant’s strategy, as different species may have different values.

The light env would then be more accuractely interpreted as effective leaf area above.

aornugent commented 3 years ago

I'm not fully sure I've understood the order of operations here, but I think the environment constructors need k_I to initialise a Canopy and do so before a strategy is called.

Parameters uses the k_I() function in it's constructor, which appears to be defined in ff16_environment, and gets the k_I value from canopy.k_I which seems a bit circular to me!

dfalster commented 3 years ago

One approach is to move k_I into strategy. That would also enable species to differ in this. I can help with this.

-- Daniel Falster

Deputy Director (Graduate Program) Evolution & Ecology Research Centre & ARC Future Fellow | School of Biological, Earth & Environmental Sciences | University of New South Wales Sydney P:+61-2-9065 9519 | A: Bdlg E26 Rm 5109 https://goo.gl/maps/iS3Jc2YmYu62 | T: @adaptive_plant https://twitter.com/adaptive_plant | W: http://danielfalster.com