search

traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:
https://traitecoevo.github.io/plant
53 stars 20 forks source link

WIP Fix enviro construction #249

Closed rafaqz closed 4 years ago

rafaqz commented 4 years ago

These changes seem to fix the problem with seed rain. But for some reason the environment always has to be constructed in parameters.validate(). I'm not sure if that's a problem or not.

A few constructor tests fail now with spline size not being zero, but the real tests all pass.

rafaqz commented 4 years ago

Ok this is updated. It's not automated yet, the hyperpar needs to be passed in. Can we merge this and the Kohiyma model before doing that to get your changes? (I can do the rebase)

Also this is failing tests for empty environment. Is there a reason it needs to be empty at any point? Can we just delete that test?

dfalster commented 4 years ago

Closed via b42ad29