search

traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:
https://traitecoevo.github.io/plant
53 stars 20 forks source link

Kohyama93 #256

Closed aornugent closed 4 years ago

aornugent commented 4 years ago

Here's our first go at implementing a new (non-FF16) model in plant.

Some tests fail due to the adaptive environment spline going out of bounds, which can be fixed by lowering the default k_I to something on the order of 1e-3.

dfalster commented 4 years ago

Only two tests failing now, due to value of k_I. What values have you found work better @aornugent ?

Feels like we need #229 to finish here!

dfalster commented 4 years ago

Sorry, I should have said - I'd really like to get all the tests passing before merging the branch in.

aornugent commented 4 years ago

Only two tests failing now, due to value of k_I. What values have you found work better @aornugent ?

I set k_I = 1e-3 and added S_D to the Rcpp class, even though it's hard coded in k93_strategy.h, for post-hoc calculations of seed rain.

Only failing tests are numerics qk and QAG 🤞