traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:
https://traitecoevo.github.io/plant
53 stars 20 forks source link

Adaptive integrator should fail on NAN? #268

Open dfalster opened 3 years ago

dfalster commented 3 years ago

We ended up with an error "Maximum number of subdivisions reached". This occurs in qag.h here, when the adaptive integration of photosynthesis just keeps refining more and more. The probably in the end was that the returned values were NAN. Qag should fail on NAN, not keep refining. Suggest adding a check for NAN when running the integrator?

dfalster commented 3 years ago

Came up in #267